Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser: Use correct ldflag (versionPrerelease) when compiling LS #1043

Merged
merged 1 commit into from
Aug 22, 2022
Merged

goreleaser: Use correct ldflag (versionPrerelease) when compiling LS #1043

merged 1 commit into from
Aug 22, 2022

Conversation

radeksimko
Copy link
Member

I noticed as part of #1041 that we released 0.29.0 (stable) as 0.29.0-dev, which is because #945 didn't follow a corresponding update of the GoReleaser config.

This PR fixes that.

Before

goreleaser build --snapshot --skip-post-hooks --rm-dist
./dist/signable_darwin_arm64/terraform-ls version
0.29.0-dev
platform: darwin/arm64
go: go1.18.5
compiler: gc

After

goreleaser build --snapshot --skip-post-hooks --rm-dist
./dist/signable_darwin_arm64/terraform-ls version
0.29.0-snapshot.dfd43fd
platform: darwin/arm64
go: go1.18.5
compiler: gc

@radeksimko radeksimko added bug Something isn't working ci Continuous integration/delivery related labels Aug 19, 2022
@radeksimko radeksimko requested a review from a team as a code owner August 19, 2022 15:25
@radeksimko radeksimko self-assigned this Aug 19, 2022
@radeksimko radeksimko merged commit 8a410a0 into main Aug 22, 2022
@radeksimko radeksimko deleted the ci-fix-goreleaser-ldflag branch August 22, 2022 09:02
@dbanck dbanck added this to the v0.29.1 milestone Aug 24, 2022
@github-actions
Copy link

This functionality has been released in v0.29.1 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@radeksimko radeksimko

Labels
bug Something isn't working ci Continuous integration/delivery related
Projects
None yet
Milestone
v0.29.1
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck